Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline XML plain string resource references #24

Merged
merged 3 commits into from
Oct 21, 2023

Conversation

DevNatan
Copy link
Collaborator

Closes #17

This code should work now

<string name="avocado">Avocado</string>
<string name="nikocado">Nikocado @string/avocado</string>
Before After
val avocado: String = "Avocado",
val nikocado: String = "Nikocado @string/avocado"
val avocado: String = "Avocado",
val nikocado: String = "Nikocado Avocado"

Note that this PR only resolves the plain string resource references, is planned that in the near future references to non-plain string references must be supported in a natural way like adding a quantity to the node when it references a plural.

@adrielcafe adrielcafe merged commit 69e08f1 into adrielcafe:main Oct 21, 2023
@DevNatan DevNatan deleted the fix/inline-xml-replacements branch November 5, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[XML] String resource references are not resolved
2 participants