Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SKIP_DELETE functionality not working #147

Closed
tarunwadhwa-paypay opened this issue Feb 28, 2022 · 2 comments · Fixed by #148
Closed

SKIP_DELETE functionality not working #147

tarunwadhwa-paypay opened this issue Feb 28, 2022 · 2 comments · Fixed by #148

Comments

@tarunwadhwa-paypay
Copy link
Contributor

tarunwadhwa-paypay commented Feb 28, 2022 •
edited
Loading

I think a return statement seems to be missing here -

files-sync-action/src/utils.js

Lines 108 to 114 in eef3915

if (SKIP_DELETE) {
logger.info(
"SKIP REMOVING FILES because `SKIP_DELETE` is set to `true`",
filePaths.map((f) => `"${f}"`).join(", ")
);
}
logger.info("REMOVE FILES", filePaths);

Shouldn't it return after logging the message? Because it is unlinking right now in every case
@adrianjost
Copy link
Owner

Yeah, that sounds like a bug.
A PR would be very welcome. 💚

tarunwadhwa-paypay added a commit to tarunwadhwa-paypay/files-sync-action that referenced this issue Feb 28, 2022
@tarunwadhwa-paypay
Fixes for adrianjost#147 adrianjost#139
710a9c2
@tarunwadhwa-paypay tarunwadhwa-paypay mentioned this issue Feb 28, 2022
Merged
@tarunwadhwa-paypay
Copy link
Contributor Author

Pr Raised.. Can you please review it..

adrianjost pushed a commit that referenced this issue Feb 28, 2022
@tarunwadhwa-paypay
Fixes for #147 #139 (#148)
9018bf4 
* Fixes for #147 #139

* Lint fixes
adrianjost pushed a commit that referenced this issue Feb 28, 2022
@tarunwadhwa-paypay @adrianjost
fix: fixes for #147 #139 (#148)
0ebc166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes for #147 #139 tarunwadhwa-paypay/files-sync-action
2 participants
@adrianjost @tarunwadhwa-paypay