-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent results on multiple target repos #103
Comments
I have noticed a couple of thinks on a first quick investigation. I haven't developed this project for a while, so I can't immediately tell what the real cause is, but here are my thoughts:
I will try to take a closer look within the next week, because this is a use-case that I think is important for most people and should work reliably. If you find out anything else, or can support me by digging into the source code yourself I would really appreciate it, since this is a pure free time project for me. And if it helps you: Here is the sync-action I am using myself regularly so sync files across my repositories: https://github.com/adrianjost/.github/blob/master/.github/workflows/sync.yml |
Thanks for taking the time to reply. It must be something to do with copy files. Git status returns an empty response if there are no changes which is what happened in the first two cases. My observations are:
If I had to work on one hypothesis it would be ensuring that the copy files operation is successful. See files-sync-action/src/utils.js Line 104 in 4d3b855
Given the lack of a reliable test case I think this will be difficult to track down so I wouldn't spend too much time on it. I would just try to improve the copy files checks and then close this issue without further thought. |
I found the issue! As you can see in this extract of the logfiles,
your Git Status is running before copying the file. And then as you can see in this bit of code: await Promise.all([Promise, Promise[]]) but I opened PR #237 to fix this |
🎉 This issue has been resolved in version 2.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Hi,
I've integrated this action and on the first run it's produced some inconsistent results.
You can see the workflow file here: https://github.com/supportpal/language-files/blob/master/.github/workflows/sync.yml
The initial workflow run logs: https://github.com/supportpal/language-files/runs/2704553466?check_suite_focus=true
You can see that some branches were updated, and others were not. None of the branches contained a
.github/workflows/test.yml
file at the time the workflow ran. I expected it to be copied frommaster
into each specified branch.Here's the log comparing two branches:
Any ideas what happened here?
The text was updated successfully, but these errors were encountered: