Skip to content

Commit

Permalink
Remove #egg from download URLs (explosion#12567)
Browse files Browse the repository at this point in the history
The current URLs will become invalid in pip 25.0. According to the pip
docs, the egg= URLs are currently only needed for editable VCS installs.
  • Loading branch information
adrianeboyd committed May 12, 2023
1 parent 4e1db35 commit 42e5043
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions spacy/cli/download.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,8 @@ def download(

def get_model_filename(model_name: str, version: str, sdist: bool = False) -> str:
dl_tpl = "{m}-{v}/{m}-{v}{s}"
egg_tpl = "#egg={m}=={v}"
suffix = SDIST_SUFFIX if sdist else WHEEL_SUFFIX
filename = dl_tpl.format(m=model_name, v=version, s=suffix)
if sdist:
filename += egg_tpl.format(m=model_name, v=version)
return filename


Expand Down

0 comments on commit 42e5043

Please sign in to comment.