-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README and add Java 8, 11, 16 Temurin Debian, Red Hat and Suse #332
Conversation
karianna
commented
Aug 6, 2021
- Update gitignore
- Update README.md to reflect how scripts work today
- First cut of Java 8 Temurin Debian files
linuxNew/jdk/debian/src/main/packaging/temurin/8/debian/changelog
Outdated
Show resolved
Hide resolved
linuxNew/jdk/debian/src/main/packaging/temurin/8/debian/control
Outdated
Show resolved
Hide resolved
@aahlenst - Would it be OK for you to review this PR and see if it makes sense to you? It's still a WIP but I want to make sure I'm heading in roughly the right direction here :-) |
linuxNew/jdk/redhat/src/main/packaging/temurin/8/temurin-8-jdk.spec
Outdated
Show resolved
Hide resolved
linuxNew/jdk/redhat/src/main/packaging/temurin/8/temurin-8-jdk.spec
Outdated
Show resolved
Hide resolved
linuxNew/jdk/redhat/src/main/packaging/temurin/8/temurin-8-jdk.spec
Outdated
Show resolved
Hide resolved
linuxNew/jdk/redhat/src/main/packaging/temurin/8/temurin-8-jdk.spec
Outdated
Show resolved
Hide resolved
linuxNew/jdk/redhat/src/main/packaging/temurin/8/temurin-8-jdk.spec
Outdated
Show resolved
Hide resolved
linuxNew/jdk/redhat/src/main/packaging/temurin/8/temurin-8-jdk.spec
Outdated
Show resolved
Hide resolved
linuxNew/jdk/redhat/src/main/packaging/temurin/8/temurin-8-jdk.spec
Outdated
Show resolved
Hide resolved
linuxNew/jdk/redhat/src/main/packaging/temurin/8/temurin-8-jdk.spec
Outdated
Show resolved
Hide resolved
linuxNew/jdk/redhat/src/main/packaging/temurin/8/temurin-8-jdk.spec
Outdated
Show resolved
Hide resolved
linuxNew/jdk/redhat/src/main/packaging/temurin/8/temurin-8-jdk.spec
Outdated
Show resolved
Hide resolved
I need to get an RPM-based VM now don't I. Anything you'd recommend for me to spin up simply in VirtualBox (yeah, yeah I should be Docker pro here but I'm a dinosaur and still like my VMs) |
@karianna Will do, give me a couple of days. |
The list of tools included in the JDK can for example be pulled from https://github.com/adoptium/installer/blob/master/linux/deb/config/jdk-8-hotspot/tools.txt. Might need an update if OpenJDK added or dropped tools lately. Lack of pack200 stood out, for example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose the spec file for Suse comes at a later stage?
linuxNew/jdk/debian/src/main/packaging/temurin/8/debian/control
Outdated
Show resolved
Hide resolved
linuxNew/jdk/debian/src/main/packaging/temurin/8/debian/jinfo.in
Outdated
Show resolved
Hide resolved
linuxNew/jdk/redhat/src/main/packaging/temurin/8/temurin-8-jdk.spec
Outdated
Show resolved
Hide resolved
linuxNew/jdk/redhat/src/main/packaging/temurin/8/temurin-8-jdk.spec
Outdated
Show resolved
Hide resolved
linuxNew/jdk/redhat/src/main/packaging/temurin/8/temurin-8-jdk.spec
Outdated
Show resolved
Hide resolved
For final verification of the package, why not. But you can run the build incl. tests on any computer running Linux or even on a Mac as long as you have both Docker and a JDK. That already catches a ton of errors. |
Yes, once I'm confident with Debian and RH :-) |
@aahlenst Thanks for the detailed review, I've updated everything except for the RPM spec file (I need to still update the tools there). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed all of it yet, but here are a small number of initial comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion to make a clarification in a comment in the code based on the responses to my feedback, but otherwise seems good.
cf4f09f
to
675b890
Compare
Yeah, I've posted in the issue tracking this. It's a file size difference and I'm really not sure if its a test data issue here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine for an initial cut.
Co-authored-by: Per Lundberg <perlun@gmail.com>
@aahlenst I can't figure out why the ZypperTests fail intermittently. Running those checks locally always passes for me. https://github.com/adoptium/installer/runs/3543407221?check_suite_focus=true is an example of the failure |
For easier analysis of test failures in CI it's best to collect Gradle's reports. Something like:
Gradle captures stdout and stderr, so we should see the output of Zypper and other tools. |
Looks like potentially fixing up the hkps access for keys has resolved the last of the issues. |