Extract select test helper to an exported function #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Ember.Test.registerAsyncHelper('select', function(app, selector, ...texts) { | ||
| let $options = app.testHelpers.findWithAssert(`${selector} option`); | ||
| // TODO: | ||
| // Can you pass an object instead of a string? |
There was a problem hiding this comment.
Both would be nice.
(this is me talking to future me)
Robdel12
changed the title
Robdel12
force-pushed
the
export-select-test-helper
branch
from
de2fd37 to
4552a07
Compare
- You can pass a jquery object or a string for a selector now - The option you're selecting isn't case sensative anymore - Rename the helper file name & import for blueprints
Robdel12
force-pushed
the
export-select-test-helper
branch
from
d7bc4bb to
a425adb
Compare
Robdel12
force-pushed
the
export-select-test-helper
branch
from
a425adb to
30550cd
Compare
Robdel12
changed the title
Robdel12
added a commit
that referenced
this pull request
Sep 4, 2016
* WIP: extract select to an exported function * Make the selector more robust - You can pass a jquery object or a string for a selector now - The option you're selecting isn't case sensative anymore - Rename the helper file name & import for blueprints * Update README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review.
This makes the
selecthelper more robust. First and foremost you can now import the select helper directly:Also you can pass a jquery object to the helper instead of just a string. This is useful in component integration tests:
select(this.$('.x-select'), 'option'). The options are now not case sensitive.Breaking changes
x-select