Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_getValue: function _getValue() { throws error #163

Closed
vinodhrajamuralidharan opened this issue Nov 18, 2016 · 5 comments
Closed

_getValue: function _getValue() { throws error #163

vinodhrajamuralidharan opened this issue Nov 18, 2016 · 5 comments

Comments

@vinodhrajamuralidharan
Copy link

Version of x-select:

Ember Version / Ember CLI Version:

**Ember Version:~2.7.0
**Ember CLI Version:^2.7.0

Expected Behavior

I have 3 select boxes. The concept is like continent - country - county

When I select continent value two times it throws error in x-select.js on '_getValue: function _getValue() ' -- like 'Cannot read property 'is' of undefined'

(Describe how things should work.)

Actual Behavior

It should not throw error

Steps To Reproduce:

  1. selecting a value first time
  2. selecting a different value immediately
  3. throw error

screen shot 2016-11-18 at 14 20 08

Ember Twiddle / Example repo / Failing test:

Please create a reproduction of your bug with this ember-twiddle. This is extremely helpful and speeds up the debugging process.

@Robdel12
Copy link
Collaborator

Hey @vinodhrajamuralidharan

Can you give master a shot and see if that fixes your issues? There are a lot of changes on master since it's basically x-select 3.0 but I think this has been fixed

@vinodhrajamuralidharan
Copy link
Author

3.0.0 is not available in the branch? How I can, mention this in the
package JSON?

Regards,
VinodhRaja.M

On Fri, Nov 18, 2016 at 4:15 PM, Robert DeLuca notifications@github.com
wrote:

Hey @vinodhrajamuralidharan https://github.com/vinodhrajamuralidharan

Can you give master a shot and see if that fixes your issues? There are a
lot of changes on master since it's basically x-select 3.0 but I think this
has been fixed


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#163 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH3PALXuiUkV0pUqlqwWhrSMwSdf3tkXks5q_c87gaJpZM4K2iG1
.

@Robdel12
Copy link
Collaborator

Instead of a version number you would use the github repo instead:

// package.json
"emberx-select": "thefrontside/emberx-select#master",

@vinodhrajamuralidharan
Copy link
Author

vinodhrajamuralidharan commented Nov 19, 2016

When I take this branch, I get the following error in x-option.js file...
screen shot 2016-11-19 at 12 09 01

@Robdel12
Copy link
Collaborator

should be closed with #164 and released with v2.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants