make tabindex default 0

adopted-ember-addons · Jul 1, 2015 · 0cf7f9f · 0cf7f9f
1 parent b825258
commit 0cf7f9f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/addon/components/x-select.js b/addon/components/x-select.js
@@ -49,9 +49,9 @@ export default Ember.Component.extend({
    *
    * @property tabindex
    * @type Integer
-   * @ default 1
+   * @ default 0
    */
-  tabindex: null,
+  tabindex: 0,
 
   /**
    * Auxiliary computed property that replaces `content.`

diff --git a/tests/acceptance/x-select-single-test.js b/tests/acceptance/x-select-single-test.js
@@ -86,13 +86,13 @@ describe('XSelect: Single Selection', function() {
 
   describe('tabindex', function() {
     it('has no tabindex by default', function() {
-      expect(this.$().attr('tabindex')).to.be.not.ok();
+      expect(this.$().attr('tabindex')).to.equal('0');
     });
 
     it('uses a passed-in tabindex if one is given', function() {
       Ember.run(function() {
         component.set('tabindex', 2);
-      }.bind(this));
+      });
       expect(this.$().attr('tabindex')).to.equal('2');
     });
   });