Grid-list: Handle tile order and length changes #809
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subtletree
changed the title
|
The pull works for our app. |
|
@miguelcobain This is good to go 👍 The current |
|
@miguelcobain bump Anyone rearranging a 😃 |
|
@miguelcobain What are your concerns regarding this PR? |
|
Any news with this PR? |
|
@miguelcobain I resolve a few conflicts of this PR that were introduced with new versions of the addon in this repo grid_list_handle_tile_order_and_length_changes, seems that it works good. What do you think of make a PR of this? |
|
@woohoou Looks like I prematurely deleted my original branch so I've moved these changes into another PR and will close this one. Just running final tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #769