Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifies exact version of qunitjs. #694

Merged
merged 1 commit into from
Apr 14, 2017

Conversation

tyleryasaka
Copy link
Contributor

qunitjs is a dependency of ember-cli-qunit. By not explicitly stating the version we want, we get the latest 2.x version. The problem is that anything after 2.2.1 breaks our tests at the moment.

@bjornharrtell
Copy link
Contributor

Funny observation: It is always 38 failing cases and they all involve explicitly calling click() on an element.

@miguelcobain
Copy link
Collaborator

Thank you for this. I'll merge this, but it would be nice to find the exact cause of the failures.

@miguelcobain miguelcobain merged commit 7539fd1 into adopted-ember-addons:master Apr 14, 2017
@wmadden
Copy link
Contributor

wmadden commented Apr 18, 2017

@miguelcobain it's probably related to this issue in ember-cli-qunit (ember-cli/ember-cli-qunit#162), which was an effect of an API change in QUnit (qunitjs/qunit#1145) which broke a lot of Ember projects.

@bjornharrtell
Copy link
Contributor

I also thought that was it, but it seems explicitly setting qunitjs to 2.3.2 (clearing out node_modules and npm install) still fails on the 38 cases. The error message is slightly different (Assertion occured after test had finished vs. Assertion after the final...) which comes from https://github.com/qunitjs/qunit/blob/master/src/test.js#L375.

@tyleryasaka tyleryasaka deleted the fix-tests branch April 18, 2017 14:21
@bjornharrtell bjornharrtell mentioned this pull request May 7, 2017
@Subtletree Subtletree mentioned this pull request Jul 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants