Consistent SASS theme colors #693
Conversation
|
@miguelcobain ping |
|
@wmadden sorry for the late reply. I had to do some changes to the filter and didn't know if they influenced this. |
Previously the values were calculated when precompiling the SASS, e.g. `{{background-color}}` -> `color($background, ‘A100’)`, and the `’A1oo’` string would be hardcoded - unchangeable from SASS.
This commit removes that precompilation step, instead outputting `color($background)`, and adds logic to the SASS `color()` mixin to infer the default hue from the `$background` hash.
|
@miguelcobain done |
|
@wmadden looks like the CI failed: https://travis-ci.org/miguelcobain/ember-paper/jobs/230832609 |
|
Ah nuts 😞 I'll fix it later
…On Wed 10. May 2017 at 18:38, Miguel Andrade ***@***.***> wrote:
@wmadden <https://github.com/wmadden> looks like the CI failed:
https://travis-ci.org/miguelcobain/ember-paper/jobs/230832609
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#693 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAvhf7Ku-pn_zQ1biZt3aUIrKsMcAJqks5r4egFgaJpZM4M8zGQ>
.
|
|
Here's an interesting regex AM itself is using: https://github.com/angular/material/blob/master/src/core/services/theming/theming.js#L889 |
|
@wmadden hope that you will and can fix this 👍 |
|
@miguelcobain I've fixed the issue on this branch but unfortunately the build is broken due to this issue with Yarn and node-sass. You've probably seen it before - locally it's fixed by running |
|
You can also add There a few suggestions floating around to add this to the |
They appeared in the recent `angular-material` changes
|
@miguelcobain looks like this issue is fixed in #709 |
|
I added the workaround for the yarn bug on master. This PR looks like it simplifies things a lot while providing more flexibility as well. 👍 |
|
Nice work @miguelcobain, looks like the build is passing now 👍 |
|
Nice work you all 👍 |
|
Nice !!! that is awesome! |
For some reason the foreground colors are set during preprocessing to fixed values, making it impossible to alter them using SASS variables. This PR replaces the generated constants with SASS expressions, making it possible to override them, and strips dead code from
lib/angular-scss-filter.js.