Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Glimmer 2 scroll for paper-select #508

Merged

Conversation

ibarrick
Copy link
Contributor

@ibarrick ibarrick commented Oct 3, 2016

under Glimmer 2 there is a new DOM mutation that wasn't there before. It's the addition of a comment node that happens under a number of circumstances, such as hovering over one of the options or the window losing focus. The reposition for paper-select includes changing the scrollTop value to center around selected values when the menu initially renders but that should only happen on initial render.

I'm asking the ember team about the nature of this node but regardless it likely is never desirable to trigger a reposition after adding it so I filtered it out of the DOM mutations that should rightfully trigger reposition.

@miguelcobain miguelcobain merged commit 2f54e04 into adopted-ember-addons:paper-menu Oct 3, 2016
@miguelcobain
Copy link
Collaborator

Thanks for looking into this @ibarrick !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants