Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finished Paper Form Component #408

Merged
merged 22 commits into from
Jul 10, 2016
Merged

Finished Paper Form Component #408

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
cc5b673
Fixed double sending of onInvalid action
shoxter Jun 29, 2016
5745ed6
Better solution -- other didn't work properly when going from NULL to…
shoxter Jun 29, 2016
90cf27f
Fixed semi-colon
shoxter Jun 29, 2016
643f458
Paper form complete
shoxter Jun 29, 2016
1f56862
Changed template to represent new container name
shoxter Jun 29, 2016
d804a78
Added ability for users who don't want to disable the submit button t…
shoxter Jul 4, 2016
d3e5163
Style fixes
shoxter Jul 4, 2016
68f497c
Fixed test errors
shoxter Jul 5, 2016
bc3c3db
Separate onInvalid changes and form changes. They are now different PRs
shoxter Jul 5, 2016
f306ca1
Merge branch 'master' into paper-form-component
shoxter Jul 6, 2016
9513e2e
Removed style attribute from tagless component
shoxter Jul 6, 2016
6cd51af
Testing readonly again
shoxter Jul 6, 2016
76f6e4d
Merge branch 'master' into paper-form-component
shoxter Jul 6, 2016
f9f99d6
Initiate isTouched in parent
shoxter Jul 6, 2016
5eccc4b
Removed container -- implemented the container's purpose inside of th…
shoxter Jul 8, 2016
5eb24fe
Removed style from tagless component
shoxter Jul 8, 2016
21d8648
Added destructuring
shoxter Jul 8, 2016
88c9033
Fixed semicolon issue
shoxter Jul 8, 2016
011b9f0
Revised paper-form now uses mixins as opposed to a hacky solution (_i…
shoxter Jul 8, 2016
a7bb8bd
Fixes
shoxter Jul 8, 2016
f09a160
Added .not
shoxter Jul 8, 2016
a9e236c
Simplified form
shoxter Jul 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addon/components/paper-form-container.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import Ember from 'ember';
export default Ember.Component.extend({
tagName: '',
attributeBindings: ['style'],
style: "width:100%",
style: 'width:100%',
customValidations: [],
hasValidation: Ember.computed('min', 'max', 'errorMessages', 'maxlength', 'required', 'customValidations', function() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

destructure all the things

return this.get('min') || this.get('max') || this.get('errorMessages') || this.get('maxlength') || this.get('required') || this.get('customValidations');
Expand Down
7 changes: 6 additions & 1 deletion addon/components/paper-form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export default Ember.Component.extend({
tagName: '',
classNames: [],
attributeBindings: ['style'],
style: "width:100%",
style: 'width:100%',
numberOfInvalids: 0,
isValid: Ember.computed('numberOfInvalids', function() {
return this.get('numberOfInvalids') === 0 ? true : false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return condition ? true : false; is equivalent to return condition;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return condition ? true : false; is equivalent to return condition;

Expand All @@ -26,6 +26,11 @@ export default Ember.Component.extend({
}
},
submit: function() {
if (this.get('isInvalid')) {
this.set('isTouched', false);
this.set('isTouched', true);
return;
}
if (this.get('parentSubmit')) {
this.get('parentSubmit')();
}
Expand Down