Divider cleanup, docs and test #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 18, 2016 05:34
…, removed the 'insetAttr' computed property in favor of binding directly with inset.
|
@andybeesee Thank you for the PR. JSCS tests are failing. |
|
Forgot to run JSCS, will have that cleaned up in a bit. I didn't realize that the attribute would be added anyway, I'll revert that and add a test for it too. |
added 3 commits
June 18, 2016 11:21
…ill still add the attribute.
…t=false, and confirm md-inset is set when inset=true
|
Thanks for your contribution! |
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing fancy here...
Added documentation and integration test for divider component.
Removed insetAttr computed property, in favor of explicitly defined inset property which defaults to null.