Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add material design tab components #212

Closed
wants to merge 1 commit into from

Conversation

bf4
Copy link

@bf4 bf4 commented Nov 11, 2015

The first commit is just copying over md-tabs-related files from mike1o1/ember-material-design

They are unmodified. Let the work begin.

Steps:

  1. Copy files for reference
  2. review files to see what to keep, what to change
  3. For each feature, update test, update implementation
    • md-tabs
    • md-tabs-content-wrapper
    • md-tabs-wrapper
    • md-tab
    • md-tab-item
    • md-tab-content
  4. Update to use ember-paper code
    • ripple
    • layout
    • styles
    • test app
    • docs

Angular material design:

Background:

per https://embercommunity.slack.com/archives/ember-paper/p1447259341000005
https://embercommunity.slack.com/archives/ember-paper/p1447168877000087

mike1234:
There are tabs in
https://github.com/mike1o1/ember-material-design/tree/ec4e58802ad87b982fa5a72eba5bb5dd950fc4dd/addon/components
if you wanted a starting point to port the tabs over. It should work
without much effort, aside from fixing up the stylesheets a bit. That
implementation works well, and I've used it in production before. Only
issue I have is personal, as I've learned a lot about Ember since
implementing, and there are some better patterns and conventions that
are available now.

Lots of ugly use of observers, and some hacks around the order that the
tabs register themselves with their parent tab wrapper

I haven't touched it in awhile, since 1.12, so I'm sure there are some
breaking changes in 2.0

ember-paper is definitely the recommended way forward

Biggest difference, really, is the paper are "native" ember
components, instead of thin wrappers over an existing jquery library.

well, not necessarily jquery, but some other implementation. ember-paper
tries to take advantage of ember conventions

though I haven't looked too closely at ember-cli-materialize lately, not
sure if that has changed

miguelcobain:
another big difference is that materialize doesn't follow google's specs

We take the styles from angular material, which is officially supported
by google.

mike123:
That's true. Though, same can be said for https://github.com/mike-north/ember-material-lite as that's a wrapper
around MDL from google

Copied unmodified. Let the work begin

per https://embercommunity.slack.com/archives/ember-paper/p1447259341000005
  https://embercommunity.slack.com/archives/ember-paper/p1447168877000087

> mike1234:
> There are tabs in
https://github.com/mike1o1/ember-material-design/tree/ec4e58802ad87b982fa5a72eba5bb5dd950fc4dd/addon/components
if you wanted a starting point to port the tabs over. It should work
without much effort, aside from fixing up the stylesheets a bit. That
implementation works well, and I've used it in production before. Only
issue I have is personal, as I've learned a lot about Ember since
implementing, and there are some better patterns and conventions that
are available now.

> Lots of ugly use of observers, and some hacks around the order that the
tabs register themselves with their parent tab wrapper

> I haven't touched it in awhile, since 1.12, so I'm sure there are some
breaking changes in 2.0

> ember-paper is definitely the recommended way forward

> Biggest difference, really, is the paper are "native" ember
> components, instead of thin wrappers over an existing jquery library.

> well, not necessarily jquery, but some other implementation. ember-paper
tries to take advantage of ember conventions

> though I haven't looked too closely at ember-cli-materialize lately, not
sure if that has changed

> miguelcobain:
> another big difference is that materialize doesn't follow google's specs

> We take the styles from angular material, which is officially supported
by google.

> mike123:
> That's true. Though, same can be said for https://github.com/mike-north/ember-material-lite as that's a wrapper
> around MDL from google
@bf4 bf4 mentioned this pull request Nov 11, 2015
@bf4
Copy link
Author

bf4 commented Jan 13, 2016

So, I'm not working on Ember any more which is why I haven't come back to this. Maybe we can auction it off?

@miguelcobain
Copy link
Collaborator

I think you can close this, unless you're up to putting it on par with #249.
That's our main goal right now.

@bf4
Copy link
Author

bf4 commented Jan 13, 2016

@miguelcobain I'll close it then. This was a business goal, so I had time. Now it'd just be fun, and I'm spread a little thin for fun :)

@bf4 bf4 closed this Jan 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants