implementing some chips functionality #115
Conversation
mansona
changed the title
|
I've updated this so it works on new master |
|
|
||
| <h2>Custom Template</h2> | ||
| \{{#paper-chips readOnly=readOnly removeItem="removeCustomItem" addItem="addCustomItem" placeholder="Add a tag" content=customFruitNames as |item|}} | ||
| <strong>{{item}}</strong> |
There was a problem hiding this comment.
We need to escape {{item}}.
|
Can we include contact chips in this PR? |
|
Yea I could probably throw it in there sometime soon, the thing that got me stumped was that I wanted to implement the same functionality as this page: https://material.angularjs.org/latest/#/demo/material.components.chips but we don't have autocomplete implemented yet. I suppose we could implement it without autocomplete 😂 |
mansona
force-pushed
the
feature/chips
branch
from
d878395 to
55305f6
Compare
| @@ -6,7 +6,6 @@ | |||
| */ | |||
|
|
|||
| body { | |||
| overflow: hidden; | |||
There was a problem hiding this comment.
I don't know why I needed to do this but if I didn't remove this I wasn't able to scroll the dummy app
|
Ok so I've brought this up to the latest and have even done a quick contact-cards implementation 🎉 If you're not happy with the contact-cards implementation I would suggest taking you up on your offer @miguelcobain to add them later i.e. remove them and worry about them later. I don't know why this is failing the build, can't figure it out from the output of travis. Can someone help me with this? |
|
@mansona Sorry for asking you this after so much time. We're preparing release v1 which will be the big thing in ember-paper. It would be great if you could bring this to be on par with latest v1 branch and angular material 1. |
|
I'll see if I can take a look sometime over the next few days 👍 |
|
Ok so now I'm going to close this in favour of #267 I have quite a few issues with this new branch but I'll start the conversation there 👍 |
Demo: https://cloudup.com/ckGCOdfqX2S
I've also added custom templates which is not in the gif above ^^