-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow kebab-cased icons (1.0) #369
Comments
this is going to be a pretty small portion of the upgrade work and it seems a shame to add complexity when a global find would let a developer convert a typical app in a few minutes. How about an assert instead? |
IMO making the migration easier and friendlier should be an important goal. It feels like the change from dashes to underscores is arbitrary (even if it isn't). Maybe a find-all will indicate all the occurrences, but there are few developers (in my experience) who could actually write the global find/replace regex to fix them all. Besides, there is a very low cost (or complexity) to supporting both, because Ember already provides a function for converting the strings. I think the benefits more than outweigh the (tiny) costs. |
@DanChadwick I'd also like to support dasherized names. It aligns better with everything else (we don't have underscores anywhere). Also, I hope they'll make this change on material icons upstream. Makes so much sense to use the same name as in the classes. |
From slack: |
Currently the master/1.0 branch only allows underscored icon names:
However, in released (0.2) ember paper, people are used to kebab cased/dasherized icon names:
I propose the master/1.0 version also supports dashes, and just converts them to underscores using Ember's
underscore
function. We should keep the benefits of ligatures, while allowing an easier upgrade path.To be clear, this means underscore (
all_out
), spaces (all out
), dashes (all-out
) and even camel cased (allOut
) will all render the ligatureall_out
. This should be a completely backwards compatible change.The text was updated successfully, but these errors were encountered: