Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidenav immediately closes upon any click - user unable to interact #204

Closed
mike1o1 opened this issue Oct 30, 2015 · 1 comment · Fixed by #253
Closed

Sidenav immediately closes upon any click - user unable to interact #204

mike1o1 opened this issue Oct 30, 2015 · 1 comment · Fixed by #253

Comments

@mike1o1
Copy link
Contributor

mike1o1 commented Oct 30, 2015

If a user opens the {{paper-sidenav component and performs any kind of click then it immediately gets closed, even if that click is on a non-link, such a toggle for a second level menu item. It appears that there is a click action handler that toggles the menu closed.

I don't think this is ideal, but I can see how it's needed to close the menu on route change. One option is to require the user to handle the didTransition event in their application route, to toggle the sidebarVisible property of the sidebar element to false.

This can be made a non-breaking, opt-in change by adding a new closeOnClick property with a default value of true. If this isn't set, then don't close on click. This way users can opt-in by explicitly setting this property to false.

@knownasilya
Copy link
Contributor

I totally need this. I put forms in my sidebar, and if the sidebar is in collapse mode it always closes when the user interacts with the form.

knownasilya pushed a commit to knownasilya/ember-paper that referenced this issue Dec 30, 2015
In response to adopted-ember-addons#204

`closeOnClick` defaults to `true`, making this option backwards compatible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants