use tabindex -1. closes #679

adopted-ember-addons · Mar 20, 2017 · c63ded6 · c63ded6
1 parent e6cb989
commit c63ded6
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/addon/templates/components/paper-menu.hbs b/addon/templates/components/paper-menu.hbs
@@ -9,6 +9,7 @@
     onFocus=(action "handleFocus")
     renderInPlace=(readonly renderInPlace)
     vPosition=(readonly vPosition)
+    tabindex=-1
   )
   content=(component "paper-menu-content"
     dropdown=(readonly publicAPI)

diff --git a/tests/integration/components/paper-menu-test.js b/tests/integration/components/paper-menu-test.js
@@ -195,4 +195,26 @@ test('keydown changes focused element', function(assert) {
       });
     });
   });
+});
+
+test('md-menu doesn\'t have a tabindex attribute', function(assert) {
+  this.render(hbs`
+    {{#paper-menu as |menu|}}
+      {{#menu.trigger}}
+        {{#paper-button iconButton=true}}
+          {{paper-icon "local_phone"}}
+        {{/paper-button}}
+      {{/menu.trigger}}
+      {{#menu.content width=4 as |content|}}
+          {{#content.menu-item onClick="openSomething"}}
+            <span id="menu-item">Test</span>
+          {{/content.menu-item}}
+          {{#content.menu-item onClick="openSomething"}}
+            <span id="menu-item2">Test 2</span>
+          {{/content.menu-item}}
+      {{/menu.content}}
+    {{/paper-menu}}
+  `);
+
+  assert.equal(this.$('md-menu').attr('tabindex'), '-1', 'no tabindex present');
 });