Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure ember-scrollable updates when rows are updated #677

Merged
merged 1 commit into from
Mar 25, 2019
Merged

ensure ember-scrollable updates when rows are updated #677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion addon/templates/components/lt-body.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
autoHide=autoHideScrollbar
scrollTo=targetScrollOffset
onScrollY=(action 'onScroll')
as |scrollbar|
}}
<div id={{concat tableId '_inline_head'}} class="lt-inline lt-head"></div>

Expand All @@ -27,7 +28,7 @@
{{#if overwrite}}
{{yield columns rows}}
{{else}}
{{#each rows as |row|}}
{{#each (if scrollbar (compute scrollbar.update rows) rows) as |row|}}
{{lt.row row columns
data-row-id=row.rowId
table=table
Expand Down
2 changes: 1 addition & 1 deletion addon/templates/components/lt-scrollable.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
onScrollY=onScrollY
as |scrollbar|
}}
{{yield}}
{{yield scrollbar}}
{{/ember-scrollable}}
{{else}}
{{yield}}
Expand Down