Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write integration tests for occlusion rendering #649

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@
"loader.js": "^4.6.0",
"yuidoc-ember-theme": "^2.0.1"
},
"resolutions": {
"ember-element-resize-detector": "0.3.0"
},
"engines": {
"node": "^4.5 || 6.* || >= 7.*"
},
Expand Down
236 changes: 236 additions & 0 deletions tests/integration/components/light-table-occlusion-test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,236 @@
import { scrollTo } from 'ember-native-dom-helpers';
import { setupRenderingTest } from 'ember-qunit';
import { render, findAll, find, click } from '@ember/test-helpers';
import { module, test } from 'qunit';
import hbs from 'htmlbars-inline-precompile';
import setupMirageTest from 'ember-cli-mirage/test-support/setup-mirage';
import Table from 'ember-light-table';
import Columns from '../../helpers/table-columns';
import hasClass from '../../helpers/has-class';
import RowComponent from 'ember-light-table/components/lt-row';
import Component from '@ember/component';
import { get, computed } from '@ember/object';

module('Integration | Component | light table | occlusion', function(hooks) {
setupRenderingTest(hooks);
setupMirageTest(hooks);

hooks.beforeEach(function() {
this.actions = {};
this.send = (actionName, ...args) => this.actions[actionName].apply(this, args);
});

test('it renders', async function(assert) {
this.set('table', new Table());
await render(hbs `{{light-table table height="40vh" occlusion=true estimatedRowHeight=30}}`);

assert.equal(find('*').textContent.trim(), '');
});

test('takes 50 rows, renders some rows with scrollbar and occludes the rest', async function(assert) {
assert.expect(3);

this.set('table', new Table(Columns, this.server.createList('user', 50)));

await render(hbs `
{{#light-table table height='40vh' occlusion=true estimatedRowHeight=30 as |t|}}
{{t.head fixed=true}}
{{t.body}}
{{/light-table}}
`);

assert.ok(findAll('.vertical-collection tbody.lt-body tr.lt-row').length < 30, 'only some rows are rendered');

let scrollContainer = 'vertical-collection';
let { scrollHeight } = find(scrollContainer);

assert.ok(findAll(scrollContainer).length > 0, 'scroll container was rendered');
assert.ok(scrollHeight > 1500, 'scroll height is 50 rows * 30 px per row + header size');

await scrollTo(scrollContainer, 0, scrollHeight);
});

test('fixed header', async function(assert) {
assert.expect(2);
this.set('table', new Table(Columns, this.server.createList('user', 5)));

await render(hbs `
{{#light-table table height='500px' id='lightTable' occlusion=true estimatedRowHeight=30 as |t|}}
{{t.head fixed=true}}
{{t.body}}
{{/light-table}}
`);

assert.equal(findAll('#lightTable_inline_head thead').length, 0);

await render(hbs `
{{#light-table table height='500px' id='lightTable' occlusion=true estimatedRowHeight=30 as |t|}}
{{t.head fixed=false}}
{{t.body}}
{{/light-table}}
`);

assert.equal(findAll('#lightTable_inline_head thead').length, 1);
});

test('fixed footer', async function(assert) {
assert.expect(2);
this.set('table', new Table(Columns, this.server.createList('user', 5)));

await render(hbs `
{{#light-table table height='500px' id='lightTable' occlusion=true estimatedRowHeight=30 as |t|}}
{{t.body}}
{{t.foot fixed=true}}
{{/light-table}}
`);

assert.equal(findAll('#lightTable_inline_foot tfoot').length, 0);

await render(hbs `
{{#light-table table height='500px' id='lightTable' occlusion=true estimatedRowHeight=30 as |t|}}
{{t.body}}
{{t.foot fixed=false}}
{{/light-table}}
`);

assert.equal(findAll('#lightTable_inline_foot tfoot').length, 1);
});

test('table assumes height of container', async function(assert) {

this.set('table', new Table(Columns, this.server.createList('user', 5)));
this.set('fixed', true);

await render(hbs `
<div style="height: 500px">
{{#light-table table id='lightTable' occlusion=true estimatedRowHeight=30 as |t|}}
{{t.body}}
{{t.foot fixed=fixed}}
{{/light-table}}
</div>
`);

assert.equal(find('#lightTable').offsetHeight, 500, 'table is 500px height');

});

test('table body should consume all available space when not enough content to fill it', async function(assert) {
this.set('table', new Table(Columns, this.server.createList('user', 1)));
this.set('fixed', true);

await render(hbs `
<div style="height: 500px">
{{#light-table table id='lightTable' occlusion=true estimatedRowHeight=30 as |t|}}
{{t.head fixed=true}}
{{t.body}}
{{#t.foot fixed=true}}
Hello World
{{/t.foot}}
{{/light-table}}
</div>
`);

const bodyHeight = find('.lt-body-wrap').offsetHeight;
const headHeight = find('.lt-head-wrap').offsetHeight;
const footHeight = find('.lt-foot-wrap').offsetHeight;

assert.equal(bodyHeight + headHeight + footHeight, 500, 'combined table content is 500px tall');
assert.ok(bodyHeight > (headHeight + footHeight), 'body is tallest element');
});

test('accepts components that are used in the body', async function(assert) {

this.owner.register('component:custom-row', RowComponent);

this.set('table', new Table(Columns, this.server.createList('user', 1)));

await render(hbs `
{{#light-table table occlusion=true estimatedRowHeight=30 as |t|}}
{{t.body rowComponent=(component "custom-row" classNames="custom-row")}}
{{/light-table}}
`);

assert.equal(findAll('.lt-row.custom-row').length, 1, 'row has custom-row class');
});

test('passed in components can have computed properties', async function(assert) {

this.owner.register('component:custom-row', RowComponent.extend({
classNameBindings: ['isActive'],
current: null,
isActive: computed('row.content', 'current', function() {
return this.get('row.content') === this.get('current');
})
}));

let users = this.server.createList('user', 3);
this.set('table', new Table(Columns, users));

await render(hbs `
{{#light-table table height='500px' occlusion=true estimatedRowHeight=30 as |t|}}
{{t.body
rowComponent=(component "custom-row" classNames="custom-row" current=current)
}}
{{/light-table}}
`);

assert.equal(findAll('.custom-row').length, 3, 'three custom rows were rendered');
assert.notOk(find('.custom-row.is-active'), 'none of the items are active');

this.set('current', users[0]);
let firstRow = find('.custom-row:nth-child(2)');
assert.ok(hasClass(firstRow, 'is-active'), 'first custom row is active');

this.set('current', users[2]);
let thirdRow = find('.custom-row:nth-child(4)');
assert.ok(hasClass(thirdRow, 'is-active'), 'third custom row is active');

this.set('current', null);

assert.notOk(find('.custom-row.is-active'), 'none of the items are active');
});

test('extra data and tableActions', async function(assert) {
assert.expect(4);

this.owner.register('component:some-component', Component.extend({
classNames: 'some-component',
didReceiveAttrs() {
assert.equal(get(this, 'extra.someData'), 'someValue', 'extra data is passed');
},
click() {
get(this, 'tableActions.someAction')();
}
}));

const columns = [{
component: 'some-component',
cellComponent: 'some-component'
}];

this.set('table', new Table(columns, [{}]));

this.actions.someAction = () => {
assert.ok(true, 'table action is passed');
};

await render(hbs `
{{#light-table table
occlusion=true
estimatedRowHeight=30
extra=(hash someData="someValue")
tableActions=(hash
someAction=(action "someAction")
)
as |t|
}}
{{t.head}}
{{t.body}}
{{/light-table}}
`);

for (const element of findAll('.some-component')) {
await click(element);
}
});
});
Loading