Remove jQuery usage #593
Merged
Remove jQuery usage #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@donaldwasserman LGTM! Thanks so much for taking the initiative on this 👏 |
|
Released as |
|
Happy to help - I’m working on the ember-scrollable piece right now. Hopefully have that done this week. Maybe you know someone who can get that merged in 😜 Do you know of anything else that uses jQuery in here? |
I don't think there is any, but we should be able to do a jquery-less build and if tests pass then 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #591
CC: @alexander-alvarez I left usage of
this.$().text().trimin the test blueprint. I'm going to make a seperate PR for updating ember + friends so we can get qunit dom working.I'm also going to make a PR against ember-scrollable to remove that little bit of jQuery as well.