replace sendAction with modern callable methods

[donaldwasserman]

This fixes #587.

CC: @buschtoens

[alexander-alvarez]

@donaldwasserman Awesome. Thanks for this.

I think this might technically be a breaking change since it prevents the superfluous bubbling up of events of ember yore, which maybe someone is unwittingly relying on. Either way, LGTM -- need to remember to do a major version bump though. Thoughts @buschtoens

[donaldwasserman]

@alexander-alvarez Thanks for taking a look at this.

On one hand it seems sort of silly to do a major version bump for this, on the other, there is likely > 0 apps still bubbling actions, I'm sure.

I'd still like to get rid of the jQuery stuff (see #591 ) so maybe we could wrap that + any other big ticket items up into a separate branch for now.

[alexander-alvarez]

Yeah -- Sounds good to me. 👌

I made a branch for the 2.x stuff https://github.com/offirgolan/ember-light-table/tree/2-x if you want to change the base. And we can publish betas from there so you can use them

[donaldwasserman]

Sounds good - I'm going to be on vacation next week, but I'm trying to get jQuery out of our app and this is one of the last big pieces that uses it.

So hopefully I can get that piece done shortly.

Thanks for the help!

[HenryVonfire]

@alexander-alvarez is there anything else left to merge this PR and publish a beta version?

PS. the Readme in npm still points to slack instead of discord

[alexander-alvarez]

@HenryVonfire @donaldwasserman
published under ember-light-table@2.0.0-beta.0 and ember-light-table@next

[fran-worley]

@HenryVonfire are you sure you got them all in this MR? I've updated to 2.0.0-beta.0 and I'm still getting a warning from onScrolledToBottom()

[fran-worley]

It looks like this MR didn't actually make the release https://github.com/offirgolan/ember-light-table/commits/v2.0.0-beta.0

[HenryVonfire]

@alexander-alvarez seems that ember-light-table@2.0.0-beta.0 and ember-light-table@next are still based on master

[alexander-alvarez]

@fran-worley @HenryVonfire
Let's try again... sorry about that. Manual workflows are 👎

These should be g2g now:
ember-light-table@2.0.0-beta.1
ember-light-table@next

[fran-worley]

@alexander-alvarez seems like beta.1 has got it covered, thanks for the quick fix!

[MichalBryxi]

I believe there are some instances of sendAction that you probably missed: https://github.com/offirgolan/ember-light-table/blob/2-x/addon/mixins/table-header.js#L181

Maybe they are not intended to be in use, but I'm basically copy-pasting the examples from your guides and stubled upon this. I'm using your @next branch that points me to 2.0.0-beta.2