Skip to content

Commit

Permalink
Merge pull request #780 from maxwondercorn/node-14
Browse files Browse the repository at this point in the history
Drop node 10
  • Loading branch information
maxwondercorn authored Jul 9, 2022
2 parents 3f59ce0 + fb3b1b4 commit 774cb35
Show file tree
Hide file tree
Showing 4 changed files with 41 additions and 24 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
#$ allowedToFail: true
#$ - scenario: embroider-optimized
#$ allowedToFail: true
#$ nodeVersion: '10'
#$ nodeVersion: '14'
#$ packageManager: yarn
#

Expand All @@ -48,7 +48,7 @@ on:
pull_request:

env:
NODE_VERSION: '12'
NODE_VERSION: '14'

jobs:
lint:
Expand Down
57 changes: 37 additions & 20 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,12 @@ language: node_js
node_js:
# we recommend testing addons with the same minimum supported node version as Ember CLI
# so that your addon works for all apps
- "10"
- "14"

dist: xenial

addons:
chrome: stable
code_climate:
repo_token: 88c79d4795cce3095bb0145b329f0a2b2748f3ec4cdf11d7949363a086206560

cache:
yarn: true
Expand All @@ -19,37 +17,56 @@ env:
global:
# See https://git.io/vdao3 for details.
- JOBS=1
matrix:
# we recommend new addons test the current and previous LTS
# as well as latest stable release (bonus points to beta/canary)
- EMBER_TRY_SCENARIO=ember-3.13
- EMBER_TRY_SCENARIO=ember-lts-3.16
- EMBER_TRY_SCENARIO=ember-lts-3.20
- EMBER_TRY_SCENARIO=ember-classic
- EMBER_TRY_SCENARIO=ember-release
- EMBER_TRY_SCENARIO=ember-beta
- EMBER_TRY_SCENARIO=ember-canary

matrix:

branches:
only:
- master
# npm version tags
- /^v\d+\.\d+\.\d+/

jobs:
fast_finish: true
allow_failures:
- env: EMBER_TRY_SCENARIO=ember-canary
- env: EMBER_TRY_SCENARIO=ember-beta
- env: EMBER_TRY_SCENARIO=ember-release

include:
# runs linting and tests with current locked deps
- stage: "Tests"
name: "Tests"
script:
- yarn lint
- yarn test:ember

- stage: "Additional Tests"
name: "Floating Dependencies"
install:
- yarn install --no-lockfile --non-interactive
script:
- yarn test:ember

# we recommend new addons test the current and previous LTS
# as well as latest stable release (bonus points to beta/canary)
- env: EMBER_TRY_SCENARIO=ember-3.13
- env: EMBER_TRY_SCENARIO=ember-lts-3.16
- env: EMBER_TRY_SCENARIO=ember-lts-3.20
- env: EMBER_TRY_SCENARIO=ember-release
- env: EMBER_TRY_SCENARIO=ember-beta
- env: EMBER_TRY_SCENARIO=ember-canary
- env: EMBER_TRY_SCENARIO=ember-default-with-jquery
- env: EMBER_TRY_SCENARIO=ember-classic

before_install:
- curl -o- -L https://yarnpkg.com/install.sh | bash
- export PATH=$HOME/.yarn/bin:$PATH
- yarn global add codeclimate-test-reporter

install:
- yarn install --no-lockfile --non-interactive
- yarn install --non-interactive

script:
- yarn lint:js
# Usually, it's ok to finish the test scenario without reverting
# to the addon's original dependency state, skipping "cleanup".
- node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO --skip-cleanup
- node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO

after_script:
- codeclimate-test-reporter < coverage/lcov.info
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ Compatibility

* Ember.js v3.13 or above
* Ember CLI v2.13 or above
* Node.js v10 or above
* Node.js v12 or above


Installation
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
"yuidoc-ember-theme": "^2.0.1"
},
"engines": {
"node": "10.* || >= 12"
"node": "12.* || >= 14"
},
"ember": {
"edition": "octane"
Expand Down

0 comments on commit 774cb35

Please sign in to comment.