Improve cells performance (#584)

* Improve cells performance * fixup! Improve cells performance
adopted-ember-addons · Aug 23, 2018 · 3350fe8 · 3350fe8
1 parent e6e1e3e
commit 3350fe8
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/addon/components/cells/base.js b/addon/components/cells/base.js
@@ -1,7 +1,7 @@
 import Component from '@ember/component';
 import { computed } from '@ember/object';
 import layout from 'ember-light-table/templates/components/cells/base';
-import cssStyleify from 'ember-light-table/utils/css-styleify';
+import { htmlSafe } from '@ember/string';
 
 /**
  * @module Light Table
@@ -26,12 +26,16 @@ const Cell = Component.extend({
 
   style: computed('enableScaffolding', 'column.width', function() {
     let column = this.get('column');
+    let columnWidth = column.get('width');
 
     if (this.get('enableScaffolding') || !column) {
       return '';
     }
 
-    return cssStyleify(column.getProperties(['width']));
+    // For performance reasons, it's more interesting to bypass cssStyleify
+    // since it leads to a lot of garbage collections
+    // when displaying many cells
+    return columnWidth ? `width: ${htmlSafe(columnWidth)};` : '';
   }),
 
   align: computed('column.align', function() {