v6.0.4 with old propagation model deprecation #506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lukemelia could you please create I believe we should publish those changes in this branch as v6.0.4 to land last deprecation to be good citizens (this branch has #499 minus breaking changes targeting v7 like #492) |
|
Merged manually and released as 6.0.4 |
|
Thanks @lukemelia! Although #492 still seem leaked into v6.0.4 https://github.com/adopted-ember-addons/ember-keyboard/releases/tag/v6.0.4 :/ |
|
Weird. Not sure how that happened. Let's roll with it and we'll cut 6.0.5 reverting that change if anyone needs it. |
leoeuclids
pushed a commit
to leoeuclids/ember-keyboard
that referenced
this pull request
Dec 11, 2023
when sortable is disabled, scrolling is blocked on ios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v6.0.4 can be published from this branch per release plan #116