Upgrade test-app to v5 app blueprint #415
Merged
+2,550
−1,254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilest
commented
Mar 4, 2025
Comment on lines
50
to
+51
| - ember-lts-3.28 | ||
| - ember-lts-4.4 | ||
| - ember-lts-4.8 | ||
| - ember-lts-4.12 |
There was a problem hiding this comment.
There's some annoying resolution issues with < 4.11. Makes the most sense to test against 4.12 anyway.
gilest
commented
Mar 4, 2025
Comment on lines
10
to
28
| name: 'ember-lts-3.28', | ||
| npm: { | ||
| devDependencies: { | ||
| 'ember-source': '~3.28.0', | ||
| 'ember-cli': '~4.12.2', | ||
| 'ember-source': '~3.28.12', | ||
| '@ember/test-helpers': '^2.9.4', | ||
| 'ember-qunit': '~6.0.0', | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| name: 'ember-lts-4.4', | ||
| name: 'ember-lts-4.12', | ||
| npm: { | ||
| devDependencies: { | ||
| 'ember-source': '~4.4.0', | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| name: 'ember-lts-4.8', | ||
| npm: { | ||
| devDependencies: { | ||
| 'ember-source': '~4.8.0', | ||
| 'ember-cli': '~4.12.2', | ||
| 'ember-source': '~4.12.0', | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Have to do a little dependency shuffling to get these old ember-source versions to still pass in CI. Might be time to drop some support soon 🤷🏻
gilest
commented
Mar 4, 2025
Comment on lines
+28
to
+29
| // TODO | ||
| 'ember/no-runloop': 'warn', |
There was a problem hiding this comment.
Set these to warn since adressing them is out of scope of this PR
|
@NullVoxPopuli why is this a breaking change🤔 |
Windvis
approved these changes
Mar 4, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main branch CI is failing due to ember-try scenarios for Ember v6.
Being a little conservative I've just taken the test-app to v5.
I think this is the simplest way to get the CI green again.
Will add comments to changes that differ from the blueprint.
Suggest label:
internal