Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary ember-decorators dependency #334

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Remove unnecessary ember-decorators dependency #334

merged 1 commit into from
Oct 30, 2020

Conversation

Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented Oct 22, 2020

Instead of using the @tagName decorator we can assign the tagName property directly, and thus avoid the extra dependency.

Resolves #331

@sbatson5 sbatson5 merged commit fe22954 into adopted-ember-addons:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbatson5 sbatson5 sbatson5 approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@ember-decorators/component dependency missing
3 participants
@Turbo87 @sbatson5 @RobbieTheWagner