Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The did-insert modifier is missing #357

Closed
sandydoo opened this issue May 5, 2021 · 0 comments · Fixed by #358
Closed

The did-insert modifier is missing #357

sandydoo opened this issue May 5, 2021 · 0 comments · Fixed by #358

Comments

@sandydoo
Copy link
Contributor

sandydoo commented May 5, 2021

The did-insert modifier is missing in apps that don’t use the @ember/render-modifiers addon directly.

Uncaught Error: Attempted to resolve `did-insert`, which was expected to be a modifier, but nothing was found.

Steps to reproduce

  1. Clone sandydoo/ember-cli-flash-missing-modifier-repro
  2. ember s
ember-cli-flash: 2.1.2
ember-cli: 3.27.0
ember-source: 3.27.0
sandydoo added a commit to sandydoo/ember-cli-flash that referenced this issue May 5, 2021
@sandydoo
Fix missing modifier error in consuming apps
e46ea58 
To be included in an app, `@ember/render-modifiers` needs to be a
dependency of this addon, not just a dev dependency.

Fixes adopted-ember-addons#357.
@sandydoo sandydoo mentioned this issue May 5, 2021
Merged
sbatson5 pushed a commit that referenced this issue May 14, 2021
@sandydoo
Fix missing modifier error in consuming apps (#358)
7897ca7 
To be included in an app, `@ember/render-modifiers` needs to be a
dependency of this addon, not just a dev dependency.

Fixes #357.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing modifier error in consuming apps sandydoo/ember-cli-flash
1 participant
@sandydoo