We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
includeExternalHelpers: true
Hi,
when using ember-cli-flash in a project that enables includeExternalHelpers in its ember-cli-babel settings, the transpiled code will throw.
includeExternalHelpers
ember-cli-babel
This happens because the addon/flash/object defines a Object class. During the transpilation babel adds the esModule marker:
addon/flash/object
Object
Object.defineProperty(_exports, "__esModule", { value: true }); // ... var Object = (_dec = (0, _computed.guidFor)('message').readOnly(), (_class = (_temp = /*#__PURE__*/function (_Ember$Object$extend) {
Due to variable hoisting, it'll try to call defineProperty on the class that ember-cli-flash defined.
defineProperty
If it's ok, I'll open a PR to rename that class name to something like FlashObject which prevents this from happening.
FlashObject
The text was updated successfully, but these errors were encountered:
fix: rename flash Object class to FlashObject to avoid transpilation …
3bb8330
…issues fixes adopted-ember-addons#341
4865482
…issues (#342) fixes #341
Successfully merging a pull request may close this issue.
Hi,
when using ember-cli-flash in a project that enables
includeExternalHelpers
in itsember-cli-babel
settings, the transpiled code will throw.This happens because the
addon/flash/object
defines aObject
class. During the transpilation babel adds the esModule marker:Due to variable hoisting, it'll try to call
defineProperty
on the class that ember-cli-flash defined.If it's ok, I'll open a PR to rename that class name to something like
FlashObject
which prevents this from happening.The text was updated successfully, but these errors were encountered: