Make this package implementation-agnostic #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than always loading Node Sass, this now requires users to pass in either Dart Sass or Node Sass as an option to the plugin. Closes adopted-ember-addons#26
7 tasks
|
Thanks @nex3, that all looks good to me 👍 However I think it would be prudent to add a CHANGELOG that makes it clear to anyone using this directly that the |
|
Done! |
|
Thanks @nex3. I'm guessing this should be released as a new major version. |
|
Published as v4.0.0 👍 Thanks :) I'll try to be quicker with the subsequent PRs :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than always loading Node Sass, this now requires users to pass in
either Dart Sass or Node Sass as an option to the plugin.
Closes #26