Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bioRad 0.8.1 #661

Merged
merged 86 commits into from
Jul 30, 2024
Merged

bioRad 0.8.1 #661

merged 86 commits into from
Jul 30, 2024

Conversation

iskandari
Copy link
Collaborator

@iskandari iskandari commented Jul 9, 2024

  • Fixes variable referencing before assignment bug in as.vpts()
  • Prints value of first attribute if mixed attributes in vpts df
  • Added test for mixed attributes test-as.vpts.R
  • Added vpts validation function
  • Added vpts validation function tests test-validate_vpts.R
  • Fixes packages in Suggests should be used conditionally #665
  • Adds vpts_schema in inst/extdata for vpts validation
  • sf and stringr added to imports, frictionless functions replaced by readr

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.28%. Comparing base (a25d6e1) to head (4f4ceea).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #661      +/-   ##
==========================================
- Coverage   82.08%   78.28%   -3.80%     
==========================================
  Files          60       60              
  Lines        3667     3666       -1     
==========================================
- Hits         3010     2870     -140     
- Misses        657      796     +139     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iskandari iskandari added this to the 0.8.0 milestone Jul 10, 2024
@iskandari iskandari self-assigned this Jul 10, 2024
@adokter adokter changed the title fixed as.vpts functions bioRad 0.8 Jul 29, 2024
Copy link
Collaborator Author

@iskandari iskandari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More intuitive conversion to vpts object, looks good

@adokter adokter changed the title bioRad 0.8 bioRad 0.8.1 Jul 30, 2024
@adokter adokter merged commit 6319e23 into master Jul 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packages in Suggests should be used conditionally
3 participants