Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .hlxignore #37

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Update .hlxignore #37

merged 2 commits into from
Nov 11, 2024

Conversation

Ruchika4
Copy link
Collaborator

The EDS team has requested that we remove root .json files from the code bus.

Links:

Before: https://main--news--adobecom.hlx.page/
After: https://hlxignore-json--news--adobecom.hlx.page/

Copy link

aem-code-sync bot commented Nov 11, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Nov 11, 2024

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

.hlxignore Outdated
@@ -1,5 +1,7 @@
.*
*.md
*.json
!*/**/*.json
LICENSE
test/*
!tools/sidekick/config.json

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L4 should make this redundant, it should be safe to remove, but it's not a showstopper if not removed either

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it.

@Ruchika4 Ruchika4 merged commit 153d182 into main Nov 11, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants