[MWPW-161562] Auto pause videos #3648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
overmyheadandbody
force-pushed
the
auto-pause-videos
branch
from
9ef12f1 to
cc184bc
Compare
overmyheadandbody
force-pushed
the
auto-pause-videos
branch
from
cc184bc to
5f9f8a7
Compare
mokimo
approved these changes
Feb 10, 2025
SilviuLCF
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Verified, testing details https://jira.corp.adobe.com/browse/MWPW-161562
robert-bogos
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that Sharepoint and MPC videos that aren't authored to be played automatically are paused when they are no longer in the viewport.
A few dev notes:
utils.js, but ultimately decided against it, since it created impractical overhead. We'd also have to call it twice under certain circumstances, since therootMarginvalue is different;figureblock uses node cloning to decorate the content, I've created https://jira.corp.adobe.com/browse/MWPW-167455 to update this behaviorResolves: MWPW-161562
Test URLs: