Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-164756: Fix inset text ol #3627

Merged
merged 1 commit into from
Feb 11, 2025
Merged

MWPW-164756: Fix inset text ol #3627

merged 1 commit into from
Feb 11, 2025

Conversation

zagi25
Copy link
Contributor

@zagi25 zagi25 commented Feb 5, 2025 •
edited by robert-bogos
Loading

Resolves: MWPW-164756

  • Axe a11y scan (with Best Practices enabled) was run for this fix, and no a11y issues were introduced.

Test URLs:

@zagi25 zagi25 requested a review from a team February 5, 2025 12:00
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Feb 5, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Feb 5, 2025

Page Scores Audits Google
📱 /drafts/ratko/mwpw-164756/text?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/ratko/mwpw-164756/text?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@SilviuLCF SilviuLCF self-requested a review February 6, 2025 09:17
SilviuLCF
SilviuLCF approved these changes Feb 6, 2025
View reviewed changes
Copy link

@SilviuLCF SilviuLCF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified, testing details https://jira.corp.adobe.com/browse/MWPW-164756

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Feb 6, 2025

Error merging 3627: MWPW-164756: Fix inset text ol Server Error

AdobeLinhart pushed a commit that referenced this pull request Feb 6, 2025
@zagi25
MWPW-164756: Fix inset text ol (#3627)
bcd4d2e
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Feb 6, 2025

Skipped 3627: "MWPW-164756: Fix inset text ol" due to file "libs/blocks/text/text.css" overlap. Merging will be attempted in the next batch

@milo-pr-merge milo-pr-merge bot merged commit 9155a75 into stage Feb 11, 2025
15 checks passed
@milo-pr-merge milo-pr-merge bot deleted the MWPW-164756-ol-inset-text branch February 11, 2025 14:38
@milo-pr-merge milo-pr-merge bot mentioned this pull request Feb 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narcis-radu narcis-radu narcis-radu approved these changes

@SilviuLCF SilviuLCF SilviuLCF approved these changes

@mokimo mokimo mokimo approved these changes

@robert-bogos robert-bogos robert-bogos approved these changes

@DKos95 DKos95 DKos95 approved these changes

Assignees
No one assigned
Labels
Ready for Stage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zagi25 @narcis-radu @SilviuLCF @mokimo @robert-bogos @DKos95