[Milo] BulkPublisher BETA Preview content should point to stage #3554
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3554 +/- ##
=======================================
Coverage 96.49% 96.49%
=======================================
Files 260 260
Lines 60763 60763
=======================================
+ Hits 58632 58634 +2
+ Misses 2131 2129 -2 ☔ View full report in Codecov by Sentry. |
cmiqueo
requested review from
sanrai,
JackySun9,
arshadparwaiz,
jedjedjedM,
sheridansunier and
shkhan91
| @@ -127,7 +127,7 @@ const showSuccessTable = (successArr) => { | |||
| tableBody.innerHTML += `<tr> | |||
| <td>${++index}</td> | |||
| <td class="ok">OK</td> | |||
| <td><a href="${pageUrl}" title="View page">${pageUrl}</a></td> | |||
| <td><a href="${pageUrl}" target="_blank" title="View page">${pageUrl}</a></td> | |||
There was a problem hiding this comment.
This is a good usability improvement for the UI. Could add rel=noopener noreferrer so the new tab can't access window.opener
|
|
||
| index += 1; | ||
| statusModal.setContent(`Publishing ${index} of ${data.length}:<br>${pageUrl}`); | ||
|
|
||
| if (pageUrl === 'stop') break; // debug, stop on empty line |
There was a problem hiding this comment.
Good cleanup reviewing developmental/test code.
| @@ -132,7 +132,7 @@ <h4>Advanced Options</h4> | |||
| </div> | |||
| <div id="use-preview-cb" class="field checkbox"> | |||
| <input type="checkbox" id="usePreview" name="usePreview" /> | |||
| <label for="usePreview">Use Preview Content (*.page)<span class="help use-preview" title="Help about this functionality">(?)</span></label> | |||
| <label for="usePreview">Use Preview Content (*.stage.*)<span class="help use-preview" title="Help about this functionality">(?)</span></label> | |||
There was a problem hiding this comment.
This is good as it clarifies that the preview environment is from a stage domain.
| @@ -147,7 +147,7 @@ const showErrorTable = (errorArr) => { | |||
| tableBody.innerHTML += `<tr> | |||
| <td>${index}</td> | |||
| <td class="error">Failed</td> | |||
| <td><a href="${pageUrl}">${pageUrl}</a></td> | |||
| <td><a href="${pageUrl}" target="_blank">${pageUrl}</a></td> | |||
There was a problem hiding this comment.
This is a good usability improvement for the UI. Could add rel=noopener noreferrer so the new tab can't access window.opener
|
Reminder to set the |
Description:
The Use Preview Content functionality is not working for some consumers because the content is behind a login wall
Posible solution:
Read the content from the publish servers .stage. instead of reading from the github branch (main- or stage-)
For example the publisher will scrape the page from:
https://business.stage.adobe.com/customer-success-stories/xfinity-creative-customer-story.html
instead of
https://main--bacom--adobecom.hlx.page/customer-success-stories/xfinity-creative-customer-story
Resolves: MWPW-165869
This is a screenshot of some of the possible results
Test URLs: