Mwpw 155418 Remove dependency on gist.github.com for gist.test.js #3549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixed the flaky test * move performance mock to beforeEach/afterEach for isolation, simplify lcpElType check * removed unused code * fixed the same issue in logWebVitals.test.js and reverted unnecessary changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3549 +/- ##
==========================================
- Coverage 96.49% 96.48% -0.01%
==========================================
Files 260 260
Lines 60730 60808 +78
==========================================
+ Hits 58599 58673 +74
- Misses 2131 2135 +4 ☔ View full report in Codecov by Sentry. |
mokimo
reviewed
Jan 27, 2025
mokimo
reviewed
Jan 27, 2025
mokimo
reviewed
Jan 27, 2025
mokimo
reviewed
Jan 27, 2025
mokimo
approved these changes
Jan 29, 2025
skholkhojaev
requested review from
narcis-radu,
overmyheadandbody,
vhargrave and
robert-bogos
robert-bogos
approved these changes
Jan 30, 2025
narcis-radu
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the dependency on gist.github.com in
gist.test.js. Previously the test was reliant on external servers, which could lead to flaky tests and slower execution times.Now the test now mocks the script creation process, to simulate the gist data locally without doing network calls.
Changes
beforeEachandafterEachhooks to handle stubbing and restoring.Resolves: MWPW-155418
Test URLs: