-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Flaky Keyboard Navigation Tests by Isolating Mobile and Desktop Viewport Settings #3532
base: stage
Are you sure you want to change the base?
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3532 +/- ##
========================================
Coverage 96.47% 96.48%
========================================
Files 260 260
Lines 60446 60582 +136
========================================
+ Hits 58317 58451 +134
- Misses 2129 2131 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of adding rules to avoid the linting errors, let's fix the errors that the linter hints at.
Discription
resolved an issue where the
setViewPort()
function in the beforeEach block of the keyboard navigation tests caused inconsistent test results. whenever the correct viewport for mobile was set, the tests would pass successfully. However, when the viewport failed to set correctly, the tests would fail, and the awaitsendKey()
function would not be handled properly.Changes
Test URLs: