Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flaky Keyboard Navigation Tests by Isolating Mobile and Desktop Viewport Settings #3532

Open
wants to merge 4 commits into
base: stage
Choose a base branch
from

Conversation

skholkhojaev
Copy link
Contributor

Discription

resolved an issue where the setViewPort() function in the beforeEach block of the keyboard navigation tests caused inconsistent test results. whenever the correct viewport for mobile was set, the tests would pass successfully. However, when the viewport failed to set correctly, the tests would fail, and the await sendKey() function would not be handled properly.

Changes

  • isolated mobile keyboard navigation tests from desktop tests to prevent viewport conflicts

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Jan 23, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (7d4a28d) to head (50d982f).
Report is 3 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff            @@
##            stage    #3532    +/-   ##
========================================
  Coverage   96.47%   96.48%            
========================================
  Files         260      260            
  Lines       60446    60582   +136     
========================================
+ Hits        58317    58451   +134     
- Misses       2129     2131     +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mokimo mokimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding rules to avoid the linting errors, let's fix the errors that the linter hints at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants