Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(mwpw-161843): favicon is loaded fast. #3530

Open
wants to merge 8 commits into
base: stage
Choose a base branch
from

Conversation

sharath-kannan
Copy link
Contributor

@sharath-kannan sharath-kannan commented Jan 23, 2025

@spadmasa spadmasa self-assigned this Jan 23, 2025
Copy link
Contributor

aem-code-sync bot commented Jan 23, 2025

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.53%. Comparing base (cf4c08b) to head (2e9583b).

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3530   +/-   ##
=======================================
  Coverage   96.53%   96.53%           
=======================================
  Files         274      274           
  Lines       61849    61849           
=======================================
  Hits        59705    59705           
  Misses       2144     2144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@spadmasa
Copy link

spadmasa commented Feb 3, 2025

@spadmasa spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage labels Feb 3, 2025
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Feb 3, 2025

Skipped 3530: "Fix(mwpw-161843): favicon is loaded fast." due to file "libs/utils/utils.js" overlap. Merging will be attempted in the next batch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants