Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including promo and localnav height to sticky blocks top when it is present #3506

Open
wants to merge 9 commits into
base: stage
Choose a base branch
from

Conversation

bandana147
Copy link
Contributor

  • Added a function to calculate what is sticky from Gnav(Promo/Localnav) to set the correct top of any sticky element

Resolves: MWPW-165847

Test URLs:

QA: https://main--federal--adobecom.hlx.page/federal/dev/blaishram/sticky-table?milolibs=mgnav-sticky-table&newNav=true

Copy link
Contributor

aem-code-sync bot commented Jan 17, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@bandana147 bandana147 added the needs-verification PR requires E2E testing by a reviewer label Jan 17, 2025
Copy link
Contributor

aem-code-sync bot commented Jan 17, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.47%. Comparing base (91d1e3d) to head (72e39a5).
Report is 1 commits behind head on stage.

Files with missing lines Patch % Lines
...bs/blocks/global-navigation/utilities/utilities.js 92.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3506   +/-   ##
=======================================
  Coverage   96.46%   96.47%           
=======================================
  Files         256      258    +2     
  Lines       60102    60167   +65     
=======================================
+ Hits        57978    58045   +67     
+ Misses       2124     2122    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aem-code-sync aem-code-sync bot temporarily deployed to mgnav-sticky-table January 17, 2025 09:25 Inactive
@bandana147 bandana147 changed the title Including promo and localnav height when it is present for sticky blocks Including promo and localnav height to sticky blocks top when it is present Jan 17, 2025
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-verification PR requires E2E testing by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants