Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-165767 Apply ContentSquare data masking attribute to BACOM Account Menu fields #3494

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

sharmrj
Copy link
Contributor

@sharmrj sharmrj commented Jan 16, 2025

  • Added data-cs-mask on elements that contain sensitive information

Resolves: MWPW-165767

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Jan 16, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@sharmrj sharmrj added the high priority Why is this a high priority? Blocker? Critical? Dependency? label Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (e4558c9) to head (7cd7f32).
Report is 7 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3494   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files         260      260           
  Lines       60417    60419    +2     
=======================================
+ Hits        58281    58283    +2     
  Misses       2136     2136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spadmasa spadmasa self-assigned this Jan 16, 2025
@spadmasa spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage labels Jan 16, 2025
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jan 16, 2025

Skipped merging 3494: MWPW-165767 Apply ContentSquare data masking attribute to BACOM Account Menu fields due to failing checks

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jan 17, 2025

Skipped merging 3494: MWPW-165767 Apply ContentSquare data masking attribute to BACOM Account Menu fields due to failing checks

2 similar comments
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jan 18, 2025

Skipped merging 3494: MWPW-165767 Apply ContentSquare data masking attribute to BACOM Account Menu fields due to failing checks

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jan 19, 2025

Skipped merging 3494: MWPW-165767 Apply ContentSquare data masking attribute to BACOM Account Menu fields due to failing checks

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jan 20, 2025

Skipped merging 3494: MWPW-165767 Apply ContentSquare data masking attribute to BACOM Account Menu fields due to failing or running checks

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jan 21, 2025

Skipped 3494: "MWPW-165767 Apply ContentSquare data masking attribute to BACOM Account Menu fields" due to file "libs/blocks/global-navigation/global-navigation.js" overlap. Merging will be attempted in the next batch

@milo-pr-merge milo-pr-merge bot merged commit ae939e3 into adobecom:stage Jan 23, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Why is this a high priority? Blocker? Critical? Dependency? Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants