-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-142145: [Milo Plans Page] Plans page Tab behavior #3420
Conversation
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3420 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 260 260
Lines 60582 60601 +19
=======================================
+ Hits 58444 58465 +21
+ Misses 2138 2136 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add unit tests for the new feature you introduced to tabs.js
@mirafedas it seems you need to increase codecov. |
@mirafedas how is it that all dependencies are being updated? (cc @yesil) i guess this is what is biting you with codecov. i had same issue with my PR #3377 |
c9a0bd6
to
016621b
Compare
@npeltier thanks for noticing! These deps got changed because I ran |
Temporarily closing this PR to get the #3482 merged first (because of the file overlap). Will reopen |
Resolves: MWPW-142145
Test URLs:
Before:
After: