Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-142145: [Milo Plans Page] Plans page Tab behavior #3420

Closed
wants to merge 3 commits into from

Conversation

mirafedas
Copy link
Contributor

@mirafedas mirafedas commented Jan 6, 2025

  • Introduced a new tab-background field in the section metadata, allowing customization of tab background color;
  • Added support for the same-width block property, ensuring equal tab widths on desktop;
  • Increased the content width on the plans page;

Resolves: MWPW-142145

Test URLs:
Before:

After:

Copy link
Contributor

aem-code-sync bot commented Jan 6, 2025

Copy link
Contributor

github-actions bot commented Jan 7, 2025

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (6cb26a3) to head (bb7ceef).

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3420   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files         260      260           
  Lines       60582    60601   +19     
=======================================
+ Hits        58444    58465   +21     
+ Misses       2138     2136    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yesil yesil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests for the new feature you introduced to tabs.js

@yesil
Copy link
Contributor

yesil commented Jan 10, 2025

@mirafedas it seems you need to increase codecov.

@npeltier
Copy link
Contributor

@mirafedas how is it that all dependencies are being updated? (cc @yesil) i guess this is what is biting you with codecov. i had same issue with my PR #3377

@mirafedas mirafedas force-pushed the mwpw-142145-plans-tabs branch from c9a0bd6 to 016621b Compare January 10, 2025 12:20
@mirafedas
Copy link
Contributor Author

@npeltier thanks for noticing! These deps got changed because I ran npm run build in mas to resolve conflicts with stage, and forgot to exclude these files from my PR. I excluded them now 👍

@mirafedas
Copy link
Contributor Author

Temporarily closing this PR to get the #3482 merged first (because of the file overlap). Will reopen

@mirafedas mirafedas closed this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants