Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-161872: Self host marketo's forms2.min.js #3215

Merged
merged 7 commits into from
Dec 11, 2024
Merged

MWPW-161872: Self host marketo's forms2.min.js #3215

merged 7 commits into from
Dec 11, 2024

Conversation

JasonHowellSlavin
Copy link
Contributor

@JasonHowellSlavin JasonHowellSlavin commented Nov 18, 2024 •
edited
Loading

  • Adds forms2.min.js to deps
  • Modifies marketo.js block code to use new dependency
  • Updates workflow for IMS to also check for form2 updates

Resolves: MWPW-161872

Context: Form at the bottom of the page

Test URLs:

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Nov 18, 2024 •
edited
Loading

Page Scores Audits Google
📱 /drafts/slavin/bacom-pages/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/slavin/bacom-pages/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (b72ed94) to head (6aa6454).
Report is 24 commits behind head on stage.

Additional details and impacted files 
@@            Coverage Diff             @@
##            stage    #3215      +/-   ##
==========================================
+ Coverage   96.41%   96.48%   +0.06%     
==========================================
  Files         246      254       +8     
  Lines       57567    59031    +1464     
==========================================
+ Hits        55504    56955    +1451     
- Misses       2063     2076      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JasonHowellSlavin JasonHowellSlavin requested review from mokimo, Brandon32 and meganthecoder and removed request for Brandon32 and meganthecoder November 18, 2024 23:16
@JasonHowellSlavin JasonHowellSlavin added run-nala Run Nala Test Automation against PR needs-verification PR requires E2E testing by a reviewer labels Nov 18, 2024
meganthecoder
meganthecoder reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@meganthecoder meganthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing forms2 being loaded twice, once from libs and once from engage

.github/workflows/update-dependencies.yaml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@Brandon32
Copy link
Contributor

Brandon32 commented Nov 19, 2024 •
edited
Loading

I'm seeing forms2 being loaded twice, once from libs and once from engage

The second forms2 is coming from the XDFrame for cross-domain posts, we need to make sure it posts correctly.
We may have to create our own XDFrame page with a relative URL at some point.

mokimo
mokimo approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@mokimo mokimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool to see this action expanding and re-used!

@JasonHowellSlavin
Copy link
Contributor Author

@mokimo @Brandon32 @meganthecoder updated the getPrDescription function as Brandon pointed out it was built with IMS in mind. Please take a look! Thank you.

@JasonHowellSlavin JasonHowellSlavin force-pushed the self-host-marketo-forms-js branch from 7409ff0 to 032106e Compare November 25, 2024 19:48
@aem-code-sync aem-code-sync bot temporarily deployed to self-host-marketo-forms-js November 25, 2024 19:48 Inactive
@Dli3 Dli3 added verified PR has been E2E tested by a reviewer Ready for Stage and removed needs-verification PR requires E2E testing by a reviewer labels Nov 27, 2024
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Nov 30, 2024

Skipped merging 3215: MWPW-161872: Self host marketo's forms2.min.js due to failing checks

1 similar comment
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Dec 3, 2024

Skipped merging 3215: MWPW-161872: Self host marketo's forms2.min.js due to failing checks

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Dec 4, 2024

Skipped merging 3215: MWPW-161872: Self host marketo's forms2.min.js due to failing checks

1 similar comment
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Dec 5, 2024

Skipped merging 3215: MWPW-161872: Self host marketo's forms2.min.js due to failing checks

@JasonHowellSlavin JasonHowellSlavin force-pushed the self-host-marketo-forms-js branch from 032106e to e6c0e4d Compare December 6, 2024 17:32
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Dec 9, 2024

Skipped merging 3215: MWPW-161872: Self host marketo's forms2.min.js due to failing checks

2 similar comments
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Dec 10, 2024

Skipped merging 3215: MWPW-161872: Self host marketo's forms2.min.js due to failing checks

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Dec 11, 2024

Skipped merging 3215: MWPW-161872: Self host marketo's forms2.min.js due to failing checks

Brandon32
Brandon32 reviewed Dec 11, 2024
View reviewed changes
libs/blocks/marketo/marketo.js
@@ -19,6 +19,7 @@ import {
loadLink,
localizeLink,
createTag,
getConfig,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to call setConfig in the unit tests and update the import mapped marketo-utils.js.

@JasonHowellSlavin JasonHowellSlavin force-pushed the self-host-marketo-forms-js branch from 8b2b6ce to 6aa6454 Compare December 11, 2024 18:59
@milo-pr-merge milo-pr-merge bot merged commit 6b2d5c6 into adobecom:stage Dec 11, 2024
14 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Dec 11, 2024
Merged
nishantka pushed a commit to nishantka/milo that referenced this pull request Dec 13, 2024
@JasonHowellSlavin @nishantka
MWPW-161872: Self host marketo's forms2.min.js (adobecom#3215)
d8f6aff 
* Adds marketo forms2.min.js to dependencies, upates dependency workflow, updates marketo.js to call form from correct location

* Adding comment for git change only

* Adding comment to hopefully see change

* Removing comments

* Typo

* Updating PR description

* Fixing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brandon32 Brandon32 Brandon32 approved these changes

@mokimo mokimo mokimo approved these changes

@meganthecoder meganthecoder meganthecoder approved these changes

Assignees

@Dli3 Dli3

Labels
Ready for Stage run-nala Run Nala Test Automation against PR verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JasonHowellSlavin @Brandon32 @meganthecoder @mokimo @Dli3