Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global links underlined by default #3166

Merged
merged 10 commits into from
Nov 12, 2024
Merged

Global links underlined by default #3166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a45f75a
a links underline, a.quite added
ryanmparrish Apr 13, 2023
f499946
added styles to omit header/footer
ryanmparrish Sep 10, 2024
eca7a5c
added default link styles for headlines and lockup area
ryanmparrish Sep 10, 2024
5b23202
minor :hover style alignment on cards-horiz, marquee-anchors, brick
ryanmparrish Oct 16, 2024
4d4de5f
removed dubs underline on links
ryanmparrish Oct 18, 2024
1eb0835
removed styles overrides to support double in horiz-card, marquee-anc…
ryanmparrish Oct 18, 2024
f52176f
[MWPW-145672] Remove Gnav global link styles
overmyheadandbody Nov 4, 2024
6dd2915
[MWPW-161624] Link farm double underline on focus
overmyheadandbody Nov 6, 2024
c9978fa
Ensure sub text in anchors is underlined correctly
overmyheadandbody Nov 8, 2024
c902817
Ensure sub text in anchors is underlined correctly
overmyheadandbody Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libs/blocks/card-horizontal/card-horizontal.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

.card-horizontal a {
color: var(--text-color);
text-decoration: none;
}

.card-horizontal a:focus {
Expand Down
4 changes: 4 additions & 0 deletions libs/blocks/global-footer/global-footer.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
list-style-type: none;
}

.global-footer a {
text-decoration: unset;
}

.global-footer a:hover {
text-decoration: none;
}
Expand Down
1 change: 1 addition & 0 deletions libs/blocks/marquee-anchors/marquee-anchors.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ html {
cursor: pointer;
position: relative;
color: var(--text-color);
text-decoration: none;
}

.marquee-anchors .links .anchor-link .heading-xs {
Expand Down
3 changes: 2 additions & 1 deletion libs/blocks/text/link-farms.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,9 @@
text-decoration: underline;
}

.link-farm.text-block a:hover {
.link-farm.text-block a:is(:hover, :focus) {
text-decoration-style: double;
outline-offset: 3px;
}


Expand Down
6 changes: 6 additions & 0 deletions libs/styles/iconography.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,12 @@ dealing w/ groups of media and associated text

.lockup-area > * { line-height: 0; }

.lockup-area a { text-decoration: none; }

.lockup-area a:hover,
.lockup-area a:focus,
.lockup-area a:active { text-decoration: underline; }

.center .lockup-area { justify-content: center; }
.right .lockup-area { justify-content: flex-end; }

Expand Down
40 changes: 32 additions & 8 deletions libs/styles/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -733,6 +733,10 @@ header.global-navigation.has-promo {
min-height: calc(var(--global-height-nav) + var(--global-height-navPromo));
}

header.global-navigation a {
text-decoration: unset;
}

@media (min-width: 900px) {
header.global-navigation.has-breadcrumbs {
padding-bottom: var(--global-height-breadcrumbs);
Expand Down Expand Up @@ -801,25 +805,46 @@ a.fragment {

a {
color: var(--link-color);
text-decoration: none;
text-decoration: underline;
}

a:hover {
text-decoration: underline;
a:hover,
a:focus,
a:active {
color: var(--link-hover-color);
}

a:has(> sub:only-child) { text-decoration: unset; }
a > sub:only-child { text-decoration: underline; }

/* Links Quiet */
a.quiet,
a.quiet:hover,
a.quiet:focus,
a.quiet:active {
text-decoration: none;
}

/* Links Static */
a.static,
a.static:hover {
a.static:hover,
a.static:focus,
a.static:active {
color: var(--text-color);
text-decoration: underline;
}

.dark a.static,
.dark a.static:hover {
.dark a.static:hover,
.dark a.static:focus,
.dark a.static:active {
color: var(--color-white);
text-decoration: underline;
}

:is(h1, h2, h3, h4, h5, h6) a,
:is(h1, h2, h3, h4, h5, h6) a:hover,
:is(h1, h2, h3, h4, h5, h6) a:focus,
:is(h1, h2, h3, h4, h5, h6) a:active {
color: currentColor;
}

/* Buttons */
Expand All @@ -829,7 +854,6 @@ a.static:hover {

.static-links a:not([class*="button"]) {
color: inherit;
text-decoration: underline;
}

.copy-link {
Expand Down
Loading