Checking if Ims is already initialized before loading it

[bandana147]

• Check if IMS is already initialized before loading it from Gnav

Resolves: MWPW-157425

Test URLs:

• Before: https://main--milo--adobecom.hlx.page/drafts/blaishram/unav-test?martech=off
• After: https://gnav--milo--adobecom.hlx.page/drafts/blaishram/unav-test?martech=off

[aem-code-sync]

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

• Re-run PSI checks
• Re-sync branch

Commits

• e6de6eb ✅ (latest)
• 6d1c931 ✅
• 0db7ebd ✅

[aem-code-sync]

	Page	Scores	Audits	Google
M	/drafts/blaishram/unav-test?martech=off
D	/drafts/blaishram/unav-test?martech=off

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.90%. Comparing base (d90dcc0) to head (e6de6eb).
Report is 24 commits behind head on stage.

Additional details and impacted files

@@            Coverage Diff             @@
##            stage    #2802      +/-   ##
==========================================
- Coverage   95.90%   95.90%   -0.01%     
==========================================
  Files         173      173              
  Lines       45842    46075     +233     
==========================================
+ Hits        43967    44187     +220     
- Misses       1875     1888      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mokimo]

I just realized imsLoaded = window.adobeIMS?.initialized; will be a boolean rather than promise, if someone calls loadIms.then() we'd return a boolean and have JS errors trying to access true.then

Would be great to change the return value to a promise that resolves and write a unit test for this scenario.

[bandana147]

I just realized imsLoaded = window.adobeIMS?.initialized; will be a boolean rather than promise, if someone calls loadIms.then() we'd return a boolean and have JS errors trying to access true.then

Would be great to change the return value to a promise that resolves and write a unit test for this scenario.

Updated the code.

[mokimo]

Cool, this looks simple, clean & full fills the adobe home request. Love it 🚀

[spadmasa]

Validation done on below url
https://gnav--milo--adobecom.hlx.page/drafts/blaishram/unav-test?martech=off

check sign in functionality
https://main--cc--adobecom.hlx.page/creativecloud?milolibs=gnav--milo--adobecom

CC : @sigadamvenkata

[milo-pr-merge]

Skipped 2802: "Checking if Ims is already initialized before loading it" due to file "libs/blocks/global-navigation/global-navigation.js" overlap. Merging will be attempted in the next batch