-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-153629: [Mini compare] Stack cards on mobile #2675
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2675 +/- ##
=======================================
Coverage 95.88% 95.89%
=======================================
Files 173 173
Lines 45771 45771
=======================================
+ Hits 43886 43890 +4
+ Misses 1885 1881 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Axelcureno
1)Some rows are having more empty spaces and not adjusted accordingly
https://main--cc--adobecom.hlx.live/creativecloud?milolibs=mwpw-153629--milo--adobecom
2) More empty spce before the CTA's
https://main--cc--adobecom.hlx.live/cz/creativecloud?milolibs=mwpw-153629--milo--adobecom
3)For Tablet : it should be two column layput per latest XD even in Individuals tab:
Need to adjust:
https://main--cc--adobecom.hlx.live/cz/creativecloud?milolibs=mwpw-153629--milo--adobecom
@Roycethan I'm seeing different, can you try refreshing the page when switching to mobile / tablet? This extra space is added normally when window is resized and not refreshed, since we calculate height with js. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marked issues are resolved, approving, Needs to be verified post other reviews for regressions
@@ -234,6 +236,10 @@ export class MerchCard extends LitElement { | |||
]; | |||
} | |||
|
|||
get isMobile() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we move this in utils.js?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Axelcureno Price Font sizes are of 24 px at https://main--cc--adobecom.hlx.live/creativecloud?milolibs=mwpw-153629--milo--adobecom
they are at about 16 px at Main, plz check thanks
Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Axelcureno
AC: Suppress the empty rows
I have removed the empty rows @Roycethan |
Fixed Thanks |
@Axelcureno aem-psi-check is failing and need attention |
a85e48b
to
a00b1a7
Compare
Skipped merging 2675: MWPW-153629: [Mini compare] Stack cards on mobile due to failing checks |
Removes mobile styles for mini compare chart and instead stacks them all in one column.
Resolves: https://jira.corp.adobe.com/browse/MWPW-153629
Test URLs:
Dummy page for the PSI check: https://mwpw-155619-cards-overlapping-sorting--milo--mirafedas.hlx.page/