Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-153629: [Mini compare] Stack cards on mobile #2675

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

Axelcureno
Copy link
Member

@Axelcureno Axelcureno commented Jul 31, 2024

@Axelcureno Axelcureno added run-nala Run Nala Test Automation against PR commerce needs-verification PR requires E2E testing by a reviewer merch card labels Jul 31, 2024
@Axelcureno Axelcureno self-assigned this Jul 31, 2024
@Axelcureno Axelcureno requested a review from a team as a code owner July 31, 2024 18:13
Copy link
Contributor

aem-code-sync bot commented Jul 31, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jul 31, 2024

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.89%. Comparing base (f92f07c) to head (a00b1a7).
Report is 4 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #2675   +/-   ##
=======================================
  Coverage   95.88%   95.89%           
=======================================
  Files         173      173           
  Lines       45771    45771           
=======================================
+ Hits        43886    43890    +4     
+ Misses       1885     1881    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@Roycethan Roycethan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Axelcureno
1)Some rows are having more empty spaces and not adjusted accordingly
https://main--cc--adobecom.hlx.live/creativecloud?milolibs=mwpw-153629--milo--adobecom
image
2) More empty spce before the CTA's
https://main--cc--adobecom.hlx.live/cz/creativecloud?milolibs=mwpw-153629--milo--adobecom
image

3)For Tablet : it should be two column layput per latest XD even in Individuals tab:
Need to adjust:
https://main--cc--adobecom.hlx.live/cz/creativecloud?milolibs=mwpw-153629--milo--adobecom
image

@Axelcureno
Copy link
Member Author

@Roycethan I'm seeing different, can you try refreshing the page when switching to mobile / tablet? This extra space is added normally when window is resized and not refreshed, since we calculate height with js.

Screenshot 2024-07-31 at 5 03 32 PM
Screenshot 2024-07-31 at 5 02 48 PM

@Axelcureno Axelcureno requested a review from Roycethan August 1, 2024 00:05
Copy link

@Roycethan Roycethan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the above 3 issues are different and are reproducible even at page refresh. #1 although happens when scrolling down - scroll down adding extra padding or disturbing the calculation.
#2 and #3 are reproducible
Let me know if more details to reproduce needed

Copy link
Contributor

github-actions bot commented Aug 1, 2024

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

libs/deps/mas/merch-card-all.js Fixed Show resolved Hide resolved
@Axelcureno Axelcureno requested a review from Roycethan August 1, 2024 21:06
Copy link

@Roycethan Roycethan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marked issues are resolved, approving, Needs to be verified post other reviews for regressions

@@ -234,6 +236,10 @@ export class MerchCard extends LitElement {
];
}

get isMobile() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move this in utils.js?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

libs/deps/mas/merch-card-all.js Fixed Show resolved Hide resolved
Copy link

@Roycethan Roycethan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Axelcureno Price Font sizes are of 24 px at https://main--cc--adobecom.hlx.live/creativecloud?milolibs=mwpw-153629--milo--adobecom
they are at about 16 px at Main, plz check thanks

@Roycethan
Copy link

@Axelcureno Price Font sizes are of 24 px at https://main--cc--adobecom.hlx.live/creativecloud?milolibs=mwpw-153629--milo--adobecom they are at about 16 px at Main, plz check thanks

Fixed

@Roycethan Roycethan self-requested a review August 14, 2024 18:18
@Roycethan Roycethan added the verified PR has been E2E tested by a reviewer label Aug 14, 2024
@Roycethan Roycethan self-requested a review August 14, 2024 18:24
Copy link

@Roycethan Roycethan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Axelcureno
AC: Suppress the empty rows

Still see Empty rows exists:
image

@Roycethan Roycethan removed the verified PR has been E2E tested by a reviewer label Aug 14, 2024
libs/deps/mas/merch-card-all.js Dismissed Show dismissed Hide dismissed
@Axelcureno
Copy link
Member Author

@Axelcureno AC: Suppress the empty rows

Still see Empty rows exists: image

I have removed the empty rows @Roycethan

@Axelcureno Axelcureno requested a review from Roycethan August 14, 2024 21:19
@Roycethan
Copy link

@Axelcureno AC: Suppress the empty rows
Still see Empty rows exists: image

I have removed the empty rows @Roycethan

Fixed Thanks

@Roycethan Roycethan added verified PR has been E2E tested by a reviewer and removed needs-verification PR requires E2E testing by a reviewer labels Aug 14, 2024
@Roycethan
Copy link

@Axelcureno aem-psi-check is failing and need attention

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Aug 15, 2024

Skipped merging 2675: MWPW-153629: [Mini compare] Stack cards on mobile due to failing checks

@milo-pr-merge milo-pr-merge bot merged commit de5bb9f into stage Aug 19, 2024
16 checks passed
@milo-pr-merge milo-pr-merge bot deleted the MWPW-153629 branch August 19, 2024 08:12
@milo-pr-merge milo-pr-merge bot mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commerce merch card Ready for Stage run-nala Run Nala Test Automation against PR verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants