Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-142084 - Accessibility: ARIA attribute needed on "Play" button for Image video links #2398

Merged
merged 5 commits into from
Jun 4, 2024
+2 −1
Merged

MWPW-142084 - Accessibility: ARIA attribute needed on "Play" button for Image video links #2398

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
202d639
added conditional and style for items center
ryanmparrish Jan 25, 2024
f790d5a
remove console
ryanmparrish Feb 6, 2024
be57e4b
add area-label: play to image-video-link
ryanmparrish Feb 6, 2024
36d7489
removed area-label from play-icon-container
ryanmparrish Feb 6, 2024
31ef7e8
Merge branch 'main' into rparrish/img-links-aria-label
ryanmparrish May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libs/utils/image-video-link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,12 @@ export default function init(el, a, btnFormat) {
const playBtnFormat = btnFormat.split(':')[1];
const btnSize = playBtnFormat.includes('-') ? `btn-${playBtnFormat.split('-')[1]}` : 'btn-large';
const pic = el.querySelector('picture');
const playIcon = createTag('div', { class: 'play-icon-container', 'aria-label': 'play', role: 'button' }, PLAY_ICON_SVG);
const playIcon = createTag('div', { class: 'play-icon-container' }, PLAY_ICON_SVG);
const imgLinkContainer = createTag('span', { class: 'modal-img-link' });
el.insertBefore(imgLinkContainer, pic);
if (btnSize) a.classList.add(btnSize);
a.classList.add('consonant-play-btn');
a.setAttribute('aria-label', 'play');
a.append(playIcon);
imgLinkContainer.append(pic, a);
}
Loading