generated from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-135873 Compress the caas hash strings #1401
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
1afbce4
MWPW-135873 Use a compressed hash for caas link
chrischrischris 8b4e3c4
Add polyfill
chrischrischris b83de72
Set initial state in configurator
chrischrischris 799d72b
Update tools/caas-import/parseCaasConfig.js
chrischrischris 0ded79e
Merge branch 'main' into caaslink-135873
chrischrischris 3951609
Merge branch 'main' into caaslink-135873
sukamat 3700d29
Merge branch 'main' into caaslink-135873
chrischrischris 19fd879
Tests and PR feedback
chrischrischris 93e87b5
Merge branch 'main' into caaslink-135873
chrischrischris ff92546
Merge branch 'main' into caaslink-135873
chrischrischris d26bfa8
Add "v2" to descriptive string
chrischrischris be01bd7
Add debug line to investigate test failure
chrischrischris 1a8c975
Remove debug code and allow for different hash header vals
chrischrischris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see an await in this function,
async
needed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getHashConfig
now can either be async (for v2 hashes) or sync (for v1 hashes). I think for clarity, since it's possible that it will be async this function should be marked as async? Otherwise you have to just know. Thoughts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, am updating the code to show why it's async.