[Release] Sync main from stage 5/14 #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* MWPW-143894 moving category authoring to separate row * MWPW-143894 more robust for edge cases * draft * simplification * other fixes not brought in * adding remnant stuff from MWPW-142148 * MWPW-143894 fix parent id * changed order of interactive marquee for Mweb users * fixed linting errors * code enhancement * spacing and padding adjustents for firefly marquee * multi image firefly marquee * css update * handle responsive design for tablet * MWPW-143904-New block: cc-mobile-app-banner (#271) * app banner in cc * app banner in CC * add review comments * code enhancement wq ! ! * Revert "MWPW-143904-New block: cc-mobile-app-banner (#271)" This reverts commit 6c5a816. * code enhancement * DOTCOM-118347 * optimize css * fix placeholder italic * add unit tests * tokenized the feature requested * handle touch device * MWPW-143894 some fixes * wip * wip * Revert "DOTCOM-118347" * add unit tests * wip * wip * blinking cursor * pull mweb changes * increase aytocycle time * Update milo-marquee.css * Update firefly-masonry.css * Optimize * unit test * optimize * remove unnecessary code * fix css * support dark masonry promptbar * css update * fix intermittent CLS issue * fix duplicate id issue for accessibility * fix unit test * change background img to img for SEO reasons * incorporate review comments * fix analytics for touch device * css * lint issue * button css fix * css fixes * css fix * css fix * css fix * css fix * css fix * fix foreground width * css fix * css fix * remove unnecessary code * Update firefly-masonry.css * fix rtl * optimize * remove importing interactive-elements.css * css fix * fix table responsiveness * fix MWPW-147643 * Update firefly-masonry.js * Update firefly-masonry.js * incorporate review comments * review comments * lint issue * lint issue * css fix * set box sizing to fix isue when caas on page * set box sizing to fix isue when caas on page --------- Co-authored-by: Nicolas Peltier <npeltier@adobe.com> Co-authored-by: sharath kannan <shkannan@adobe.com> Co-authored-by: sharathkannan <138484653+sharath-kannan@users.noreply.github.com> Co-authored-by: Aishwarya Mathuria <mathuria@adobe.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com> Co-authored-by: Saloni Jain <6162294+salonijain3@users.noreply.github.com>
High LCP was seen for hue-sat marquee. Resolves: MWPW-146221
* Update firefly-masonry.js * Update firefly-masonry.js * fix lint issues * Update firefly-masonry.js * Update firefly-masonry.js * incorporate review comments
Functionality of continue to photoshop added on Hue-Sat marquee. Resolves: MWPW-142976 Test URLs: Before: https://main--cc--adobecom.hlx.live/drafts/suhjain/interactive-marquee/continuetops After: https://openinps--cc--adobecom.hlx.live/drafts/suhjain/interactive-marquee/continuetops
Continue to photoshop button is not seen working in stage ,proxy denied error is seen. Thus changed the dev env to stage. Resolves: MWPW-148165
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
aishwaryamathuria
approved these changes
May 15, 2024
salonijain3
approved these changes
May 15, 2024
|
Validation done in stage on firefly marquee and hue sat slider flow on the below urls
https://www.stage.adobe.com/creativecloud/animation/testdoc/marquee621.html
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging following PRs to main -
Test URLs:
Before: https://main--cc--adobecom.hlx.live/careers?martech=off
After: https://stage--cc--adobecom.hlx.live/careers?martech=off