Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-140669][Milo - Interactive marquee] missed specs from Figma file #2, #3 and #4 #151

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

drashti1712
Copy link
Collaborator

@drashti1712 drashti1712 commented Dec 21, 2023

  • Resolved the discrepancies that listed in the jira for GenFill marquee (issue 2, 3 and 4)
  • Changed the button to 50px height (button-xl)
  • Modified the structure of the interactive marquee so that it matches Marquee medium.
  • The icon text is set to 18px font size across all breakpoints

Resolves: MWPW-140669

Test URLs:

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9822a70) 89.83% compared to head (c55cc1f) 89.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   89.83%   89.83%           
=======================================
  Files           8        8           
  Lines         679      679           
=======================================
  Hits          610      610           
  Misses         69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drashti1712 drashti1712 changed the title [MWPW-140669][Milo - Interactive marquee] missed specs from Figma file #2 and #4 [MWPW-140669][Milo - Interactive marquee] missed specs from Figma file #2, and #4 Jan 5, 2024
@drashti1712 drashti1712 changed the title [MWPW-140669][Milo - Interactive marquee] missed specs from Figma file #2, and #4 [MWPW-140669][Milo - Interactive marquee] missed specs from Figma file #2, #3 and #4 Jan 5, 2024
@spadmasa
Copy link
Collaborator

spadmasa commented Jan 5, 2024

Verified the below flows in the url

Changed the button to 50px height (button-xl)
Modified the structure of the interactive marquee so that it matches Marquee medium.
The icon text is set to 18px font size across all breakpoints

https://genfill-fix--cc--drashti1712.hlx.live/drafts/drashti/MWPW-137345/genfill-container
50 px is seen on the marquee button in desktop/mobile/tablet
image
image

image

icon text is set to 18px font size across all breakpoints
image
image

Modified the structure of the interactive marquee so that it matches Marquee medium.
image
image
image

image

Copy link

aem-code-sync bot commented Jan 9, 2024

Page Scores Audits Google
/drafts/drashti/MWPW-137345/genfill-container?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@salonijain3 salonijain3 merged commit a9948ec into adobecom:main Jan 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants